| Re: [AD] Patch for fixing missing NSAutoreleasePools |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
On Sun, 27 May 2012 02:17:30 -0600
Trent Gamblin <trent@xxxxxxxxxx> wrote:
> On 2012-05-27, at 2:06 AM, Evert Glebbeek wrote:
> > Which functions? I can do a more specific test if I know where to
> > look; it's possible I just didn't test those while runnign random
> > examples.
>
> I don't remember specifically. When I applied the patch I opened two
> terminals, one with the patch and one to look at each file that was
> patched. I looked at each patched function and made sure there were
> no errors (there were a couple.) As I was scrolling through the
> patched files I noticed other functions that the patch didn't touch
> that used Objective C stuff. It's entirely possible those are safe
> though. They could be called from one of the functions that did have
> Autorelease pools added, or something like that.
>
Not all OSX functions require a pool - only those who autorelease
something. But yes, I guess it wouldn't hurt having a pool around all
of them.