Re: [AD] Missing system vtable entries on OS X

[Elias Pschernig <elias.pschernig@xxxxxxxxxx>]

On Thu, 2010-01-28 at 13:41 -0500, Evert Glebbeek wrote:
> 
> So anyway, question: does al_get_display_mode() work as intended here?
> I get the impression from what you said that perhaps it doesn't.
> 

It does - as far as I can tell. I think al_get_display_mode() only has
the function to get the possible fullscreen dimensions. If you don't use
fullscreen, you don't need it.

al_get_display_format_option() on the other hand is for all the
additional things which are relevant to fullscreen as well as windowed
(but sometimes the available things may be different for
fullscreen/windowed). Like super sampling, depth buffer, exact pixel
format, ... everything listed here so far:

http://docs.liballeg.org/display.html#al_set_new_display_option

Right now I can't see a use-case where you'd have to get all the
possible combination beforehand, so I'd propose to remove these two
functions again:

al_get_num_display_formats
al_get_display_format_option

al_create_display() would keep working the way it already does.

I remember I wanted them once because I never trusted our X11
visual-selection scorer. But in that specific X11-only case a config
variable to disable certain X11 visuals would work better. Also GLX 1.3
works without the scorer (just like OSX then I assume). Not sure if it
was the only reason we added the functions.

For the cross-platform way to e.g. request a depth buffer it really
should be enough to do:

al_set_new_display_option(ALLEGRO_DEPTH_BUFFER, 1, ALLEGRO_REQUIRE)

(which reminds me, have to add ALLEGRO_DEPTH_BUFFER as an option)

-- 
Elias Pschernig <elias.pschernig@xxxxxxxxxx>