| Re: [AD] msvc makefile patch |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
- To: alleg-developers@xxxxxxxxxx
- Subject: Re: [AD] msvc makefile patch
- From: Matthew Leverton <meffer@xxxxxxxxxx>
- Date: Mon, 30 Jan 2006 02:39:02 -0600
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=V2XtKZKmW7ZQopwl61A2nD0Y/ELcevjTwdnTQ/vhmSDtCVzuerOASqzwf2g2l5D0KZu1NJgqk0XUrYqy43GHzngngHMS+xlDPVKO/04XjUQvQA3F7On+xm7GHzLr0ujr6D4NsFGEGjREPp/Ux+hpO5YRTPccCfh788G6Wv9Gv40=
On 1/29/06, Evert Glebbeek <eglebbk@xxxxxxxxxx> wrote:
> On Saturday 28 January 2006 09:57, Matthew Leverton wrote:
> > 1) Adds an EMBED_MANIFEST define that automatically gets set if MSVC8
> > is being used with the (default) non-static C runtime.
> >
> > 2) Embeds the manifest for the DLL's automatically. Manifests for
> > other executables are not automatically embedded, but could be by
> > running the "misc\embedman.bat all" command or hacking the makefile
> > further... [embedman.bat is attached to a previous e-mail.]
>
> I've commited this part.
>
Couple things:
ifdef COMPILER_MSVC8
EMBED_MANIFEST = 1
endif
If STATICRUNTIME is set, then EMBED_MANIFEST should not be set.
(You'll notice I had it in the else before, which has been removed for
now.) I don't know how makefile syntax works with multiple conditions,
but it needs to be something like:
ifndef STATICRUNTIME
ifdef COMPILER_MSVC8
EMBED_MANIFEST = 1
endif
endif
Also, my patch was missing a subst() call:
misc\embedman.bat $(DLL_NAME) 2
should be:
misc\embedman.bat $(subst /,\,$(DLL_NAME)) 2
--
Matthew Leverton