Re: [AD] Version check patch

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


> tjaden@xxxxxxxxxx wrote:
>> It makes it harder to sift through patches later on.  Don't make
>> gratuitous whitespace changes, please!  If you must, do it in a separate
>> patch or combine it with one for general cosmetic fixes.
>
> I didn't realize it happened until after I made the patch. It's just
> kind of hard to tell since you can't see the whitespace. The only time I
> can tell is when the patch is already made (and I happen look through
> it). And short of reconfiguring the editor (and SciTE can be a pain to
> reconfigure), undoing the patch, and redoing all the changes, there's
> nothing that can be done.

If the patch is small enough, you can easily edit the patch to remove
offending chunks by hand.  (Emacs also has a diff mode which helps with
patch editing.)

Peter





Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/