| Re: [AD] Version check patch |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
> Elias Pschernig wrote:
>> Yes, really crude.. it has lots of unrelated whitespace changes.
>> Definitely shouldn't apply it like that.
>
> The whitespace changes was my editor stripping extra whitespace before
> line-returns. IMO, it wouldn't hurt to apply it with that since the
> whitespace is wasteful and unnecessary, not does it hurt anything gone.
It makes it harder to sift through patches later on. Don't make
gratuitous whitespace changes, please! If you must, do it in a separate
patch or combine it with one for general cosmetic fixes.
Peter