| Re: [AD] Version check patch |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
On Sun, 2004-11-28 at 15:40 +0100, Evert Glebbeek wrote:
> On Sunday 28 November 2004 14:10, Chris wrote:
> > Attached is a crude patch that enables install_allegro to check the
> > program's version against the library's, and fail if they don't match.
>
Yes, really crude.. it has lots of unrelated whitespace changes.
Definitely shouldn't apply it like that.
> out, this is what I did. First, I renamed install_allegro to
> _install_allegro and added _get_allegro_version. Then I added the
> MAKE_VERSION macro to create the version numbers to check against.
> Finally, I added a static inline install_allegro in system.h which
> checks the version returned by _get_allegro_version with the version
> being compiled before calling _install_allegro.
Makes sense. Just, "static inline" is not what is used in allegro for
this, use AL_INLINE instead. And yes, I agree, we should get rid of all
the AL_INLINE AL_CONST AL_EXTERN whatever stuff for 4.3.x :)
> Didn't Elias submit a patch for this as well a while back?
> Anyway, looks good to me!
>
Yes, never applied it though.. Chris already suggested something like
this patch back then I think. Anyway, looks good to me, with the 2
cosmetic changes.