| Re: [AD] XOR drawing under X11 (and what is _xwin_in_gfx_call) |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
- To: alleg-developers@xxxxxxxxxx
- Subject: Re: [AD] XOR drawing under X11 (and what is _xwin_in_gfx_call)
- From: Chris <chris.kcat@xxxxxxxxxx>
- Date: Fri, 26 Nov 2004 15:38:06 -0800
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:return-path:message-id:date:from:user-agent:x-accept-language:mime-version:to:subject:references:in-reply-to:x-enigmail-version:x-enigmail-supports:content-type:content-transfer-encoding; b=fp4fAJlgjO2j7gJLwsoz04KDOOr/ELyATLWfBdqCtc1zPTqOvt6ZorMfaCQeA1k24q6ZKY9HlFMi0fespzboyDlX5VPv8k2pkGL2GbKi592UZKFQDiB4GOxxj5cco1oTbwQsayvye8nQ/fi4ehofi1qX+O/9uee+xxh2xbOd8k8=
Elias Pschernig wrote:
Yes, I must admit, I tried sneaking in that naming change :) The
underscore should only be used for non-static functions IMHO. I think
that's how it is already handled in other parts of the source (not in
the x11 ones). Probably should update hacking.txt with info about this.
Yeah, I did kinda wonder why even static functions were prefixed. AFAIK,
the prefix was to avoid name clashes, but you don't really need to worry
about that with static functions.
So I guess if it's a vote, I don't mind static functions not being prefixed.
Yes, gcc will inline them either way - but inlining can't hurt.
Actually, GCC will only inline non-inline'd functions if you use
-finline-functions or -O3 (which implies the former); neither of which
Allegro use. As well, -finline-functions doesn't gaurantee that simple
functions like that will be inlined.
It
should be AL_INLINE then. And for 4.3.x, let's drop AL_INLINE as well as
AL_STATIC. The only compiler without them must be sunos gcc 2.8.1 or
something :P
Isn't inline part of the C(++) standard? In either case, I think it'd
just be better to define 'inline' for broken compilers (as well as
'const'), instead of making AL_INLINE and AL_CONST, which can look
rather ugly.
And AFAIK, MSVC doesn't have 'inline'.. but it does have '_inline'.
I'm almost sure now this is only for the signals version - just not sure
how it works. If something wants to draw while drawing is in progress,
it only updates the back-buffer(?)
Right (and even then, only if it's drawing to the memory bitmap itself,
not the display). Although if that ever happened, then the display would
never be updated with the second drawing operation, unless it happened
to be inside the same area as the first (which would cause its own
problems).
Yes. So very odd. Would need to find Michail Bukin or Geroge Foot and
ask them what this is about :)
Weren't we going to drop the SIGALRM version anyway? When do we plan on
doing that?