Re: [AD] XOR drawing under X11 (and what is _xwin_in_gfx_call)

[Chris <chris.kcat@xxxxxxxxxx>]

Elias Pschernig wrote:
> In any case, having to preserve the XOR state seems too much hassle (and
> possibly performance loss) compared to no gain (when does XOR need to be
> done by X11?) at all. Just let's have X11 draw always in solid mode,
> with no state information to carry around, for now.

What you're saying makes sense. XOR mode isn't really used that much by 
speed-intensive programs either.. not on video bitmaps, anyway. I only 
added it because I figured X would be able to do it a lot faster than we 
could (perhaps hw accelerated).

Did you try making X11 only use the GXsolid state and see if that fixes 
the problem?


> For example nobody knows
> what _xwin_in_gfx_call is for exactly, apparently it can be set also
> with the pthread driver, so it's not just something for the signals
> version.

This needs to be looked at again. Two graphics calls should not be able 
to affect video bitmaps at the same time with the new locking mechanism. 
But it seems I misunderstood that the driver functions need to handle 
the locking, instead of the Allegro base system.