Re: [AD] plugins.h on MinGW32 2

["Eric Botcazou" <ebotcazou@xxxxxxxxxx>]

> When using the new version 2 of MinGW32 (gcc 3.2), the make process dies
> on the plugins.h file, due to a garbage character at the end. Looks like a
> stray CR/LF, and you can see it in notepad.

My binary editor shows a trailing 0x1A character on Win98.

> The following patch of "makefile.mgw" on line 553 fixes it (at least on
> Win2000):
>
> --
>    define GENERATE_PLUGINS_H
>       copy /B tools\plugins\*.inc obj\mingw32\plugins.h
>    endef
> --

Confirmed.

> It seems that by not specifying the /B (binary) switch, extra characters
> are getting added?

Probably a bug... huh... a feature I mean.

> I'm pretty sure that all versions of `copy' ranging from DOS to WinXP have
> the /B switch.

Very likely indeed.

> Also, any other makefiles (DJGPP / MSVC / BCC ?) that use the the `copy
> *.inc >' syntax should be updated as well.

I don't know: should we really add this "preventive" fix to all the other
makefiles ? Either way, the complete patch is attached.

- Eric

Attachment: makefile_copy.zip
Description: Zip compressed data