Re: [AD] COLORCONV_KEEP_TRANS in datafiles + cleanup

["Elias Pschernig" <eliaspschernig@xxxxxxxxxx>]

> 
> I meant a little comment in the code, explaining the 'if' test.

Oh, heh, I guess the new if() is quite self-explanatory, looking at the flag
which is tested and seeing the next line..
 
> 
> After looking a little bit more at the code in datafile.c:fixup_datafile(),
> I've run into two problems:
> - inconsistent with read_bitmap(), the code expects 15-bit bitmaps to be
> saved in 15-bit format. I don't understand why (Shawn ?).

The reason is simple: datafiles in memory store 15bit-bitmaps as 15bit, and
dat2s stores the memory format of datafiles, and not the on-disk format :)
(I still think it was a bad idea to store 15bit data as 16bit in the first
place - it justs least to confusion.)

> - you said there is no problem with RLE sprites. Why ? 0xf83f is again
> converted to MASK_COLOR_15, isn't it ?
> 

Well, I was surprised by it myself, because in fact, the EOL marker (which
again is 0xf83f for 15bit RLE sprites) does seem to be placed into the data
area of RLE sprites, in line 729 (after applying my patch). But the 15bit
RLE drawer obviously is smart enough to draw the sprites properly
nevertheless. So there's a hidden feature: With RLE sprite, you can
actually display the magenta color on the screen with Allegro :)

--
Elias Pschernig