Re: [AD] Allegro 5 new config routines, alpha 2

["David A. Capello" <dacap@xxxxxxxxxx>]

On vie, feb 08, 2002 at 03:40:36 +1100, Peter Wang wrote:
> On 2002-02-07, Angelo Mottola <a.mottola@xxxxxxxxxx> wrote:
> >    /* Avoid collisions (if any) */
> >    while ((strcmp(entry->name, name)) && (entry->next))
> >       entry = entry->next;
> >    if (strcmp(entry->name, name))
> >       return NULL;
> 
> Just quickly, there seems to be lots of these.  strcmp'ing might be
> unnecessarily called twice.
> 
>      while (entry && strcmp(entry->name, name))
> 	entry = entry->next;
>      if (!entry)
> 	return NULL;
> 
> .. or something like that might be better.

Here a patch with:

  - Peter Wang recomendation;
  - The `float' type;
  - Unification of all types in an `union';
  - Some wish-list;

-- 
David A. Capello
dacap@xxxxxxxxxx
http://www.davidcapello.com.ar

Attachment: config.diff.gz
Description: Binary data