Re: [AD] This time GFX_SAFE for real

[Peter Wang <tjaden@xxxxxxxxxx>]

Grzegorz Adam Hankiewicz <gradha@xxxxxxxxxx> wrote:
> 
> Aha, here goes. This patch modifies most examples to make them work with
> the new GFX_SAFE fb behaviour. The nice thing about it is that users on
> other platforms should see _no_ visible change in their behaviour. I
> repeat: if somebody sees something changed, that is a bug I introduced and
> should be fixed.

Committed, with some formatting fixes.  Also fixed exkeys.c and
exstream.c (needed opaque `text_mode').

I left the "!?!" in the "Couldn't set an 8bpp resolution!?!"
comments, but it's not quite as unbelievable as it sounds.  Linux
console users without fbcon and running without root privileges will
see this very annoyingly often.

> > > That was my suggestion. It would be good if we could agree on a
> > > "what-does-this-driver-have-to-do" document.
> > 
> > - sets most convenient (read: any) resolution
> > - sets most convenient (read: any) color depth
> > - if in a windowing system, use a window
> 
> Yes, but what should happen with that window? GDI under windows, or maybe
> should try first overlay driver? Should it set 8bpp or the desktop color
> depth? 

I think it should use the desktop color depth, keeping with the
fbcon driver's philosophy of "Use what you've got".

-- 
MCMONIA (muk MOAN ee uh, chemical symbol: Mc), n.  Noxious gas created by
fast-food employee mopping under your table while you're eating.
	-- Rich Hall, "Sniglets"