Re: [chrony-dev] [PATCH] refclock: add SENSORS driver for OpenBSD timedelta sensors

[Atanas Vladimirov <vlado@xxxxxxxxx>]

On 2026-07-22 13:18, Atanas Vladimirov wrote:
> On 2026-07-22 12:58, Miroslav Lichvar wrote:
> > On Sun, Jul 19, 2026 at 01:53:36AM +0300, Atanas Vladimirov wrote:
> > > +  name = RCL_GetDriverParameter(instance);
> > > +  if (!name || name[0] == '\0') {
> > > +    LOG(LOGS_ERR, "Missing sensor device");
> > > +    return 0;
> > > +  }
> >
> > This check shouldn't be needed as the config parser requires a driver
> > parameter to be present in the directive. The other drivers don't have
> > it. If would need to be a fatal error anyway (misconfiguration).
> >
> > I can remove it if that's ok with you. The rest of the patch looks
> > good to me.
> >
> > Thanks,
>
> Yes, I'm okay. Please feel free to make any changes :)

Or if you wish, I can send an updated patch, just let me know what is 
easier for you.

--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble?  Email listmaster@xxxxxxxxxxxxxxxxxxxx.