| Re: [chrony-dev] [PATCH] refclock: add SENSORS driver for OpenBSD timedelta sensors |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: Atanas Vladimirov <vlado@xxxxxxxxx>
- Subject: Re: [chrony-dev] [PATCH] refclock: add SENSORS driver for OpenBSD timedelta sensors
- From: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
- Date: Wed, 22 Jul 2026 11:58:38 +0200
- Cc: chrony-dev@xxxxxxxxxxxxxxxxxxxx, tom@xxxxxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784714328; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jQKCCquV3BN4a+0L/vRUJA7264Epk2aS1dGLRGJbnjc=; b=jVhY9aBSiAVvpZFjmpAL4229JXk+AzDNFv5EezKQqLELrFsX73qAG7UQKKS2EZt7c7FKlR mu+LV5TIC/bCfm8uk6bDXYhnlVGI/eAM8xXSUyMsdU+MvHi2NY+m8OT+4rzvwEf5d8ihSw N2WWsVZ8w3ZrKnOZ/ReDiWIwGwxAkIE=
On Sun, Jul 19, 2026 at 01:53:36AM +0300, Atanas Vladimirov wrote:
> + name = RCL_GetDriverParameter(instance);
> + if (!name || name[0] == '\0') {
> + LOG(LOGS_ERR, "Missing sensor device");
> + return 0;
> + }
This check shouldn't be needed as the config parser requires a driver
parameter to be present in the directive. The other drivers don't have
it. If would need to be a fatal error anyway (misconfiguration).
I can remove it if that's ok with you. The rest of the patch looks
good to me.
Thanks,
--
Miroslav Lichvar
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.