Re: [chrony-dev] makestep command sometimes makes chrony stop reading its sources

[ Thread Index | Date Index | More chrony.tuxfamily.org/chrony-dev Archives ]


On Tue, Jan 26, 2010 at 02:28:04PM +0100, Hattink, Tjalling (FINT) wrote:
> After executing some tests I found out that the scheduler goes berserk
> when the LCL_MakeStep function steps the system time back into the
> past. The poll_timeout function in refclock.c schedules a new timeout
> before it returns, and because the scheduler still acts in the
> future in the dispatch_timeouts function it keeps calling the
> poll_timeout function. To prevent this to happen I've replaced the
> "while" statement on line 444 of sched.c with "if" so that it is
> only executed once. The while loop in SCH_MainLoop, line 546-547
> will take care of any successive elements, but the current "now"
> time is updated to the newly set system time after each execution
> run.

Ok, that makes sense.

> Maybe this is not the most elegant solution, so please take a good
> look at it.

I don't see how it could be handled better. Thanks.

-- 
Miroslav Lichvar

---
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble?  Email listmaster@xxxxxxxxxxxxxxxxxxxx.


Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/