| Re: [chrony-dev] makestep command sometimes makes chrony stop reading its sources |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
On Thu, Jan 21, 2010 at 03:00:19PM +0100, Hattink, Tjalling (FINT) wrote:
> >The freeze is probably worth investigating.
>
> I've investigated it and it has actually nothing to do with makestep.
> When I set the RTC clock 40 months back or forward in time, the chrony
> daemon freezes as soon as it selects a reference clock. I think there is
> an integer overflow somewhere.
Yes, I reproduced it too. The calculated timeout for ending fast slew
(which should be 40 / 0.08 months) overflows, the timestamp is
negative, the handler is immediately called which adds the timeout
again...
We can limit the timeout to something reasonable like one month or add
checks for signed overflows to UTI_ functions (which will possibly
have a performance impact).
How much do we care about year 2038?
--
Miroslav Lichvar
---
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.