Re: [vhffs] autotools for #542 - revision 2

[Sébastien Le Ray <beuss@xxxxxxxxxxxxx>]

Le Sun, 15 Apr 2007 20:34:46 +0200,
Sébastien Le Ray <beuss@xxxxxxxxxxxxx> a écrit :

> Le Fri, 13 Apr 2007 07:23:55 +0200,
> Sébastien Le Ray <beuss@xxxxxxxxxxxxx> a écrit :
> 
> > Le Thu, 12 Apr 2007 23:17:21 +0200,
> > Alexandre Ghisoli <alexandre.ghisoli@xxxxxxx> a écrit :
> > 
> > > Le jeudi 12 avril 2007 à 18:50 +0200, Sébastien Le Ray a écrit :
> > > > Le Thu, 12 Apr 2007 15:28:20 +0200,
> > > > Sébastien Le Ray <beuss@xxxxxxxxxxxxx> a écrit :
> > > 
> > > > Hu, vhffs.conf is overriden in every case:
> > > > 
> > > > make  install-data-hook
> > > > make[3]: entrant dans le répertoire
> > > > « /home/sebastien/vhffs/vhffs-backend » /usr/bin/install -c -m
> > > > 644 vhffs.conf /etc/vhffs/vhffs.conf make[3]: quittant le
> > > > répertoire « /home/sebastien/vhffs/vhffs-backend »
> > > > 
> > > > In /etc/vhffs I've vhffs.conf and vhffs.conf.dist, both with the
> > > > same timestamp.
> > > 
> > > In facts, I cannot reproduce this bug. Here is the make install
> > > with configure default options, and with a
> > > configured /etc/vhffs/vhffs.conf :
> > > 
> > > make[1]: entrant dans le répertoire
> > > « /home/staff/alex/workspace/vhffs/vhffs-backend »
> > > make[1]: Rien à faire pour « install-exec-am ».
> > > test -z "/usr/share/vhffs/backend" || /bin/mkdir -p
> > > "/usr/share/vhffs/backend"
> > >  /usr/bin/install -c -m 644 'src/pgsql/initdb.sql'
> > > '/usr/share/vhffs/backend/initdb.sql'
> > > test -z "/etc/vhffs" || /bin/mkdir -p "/etc/vhffs"
> > >  /usr/bin/install -c -m 644 'conf/vhffs.conf.dist'
> > > '/etc/vhffs/vhffs.conf.dist'
> > > test -z "/usr/lib/vhffs/listengine" || /bin/mkdir -p
> > > "/usr/lib/vhffs/listengine"
> > >  /usr/bin/install -c -m 644 'mails/largefile-copyfailed'
> > > '/usr/lib/vhffs/listengine/largefile-copyfailed'
> > >  /usr/bin/install -c -m 644 'mails/largefile-finished'
> > > '/usr/lib/vhffs/listengine/largefile-finished'
> > >  /usr/bin/install -c -m 644 'mails/largefile-upload'
> > > '/usr/lib/vhffs/listengine/largefile-upload'
> > > make  install-data-hook
> > > make[2]: entrant dans le répertoire
> > > « /home/staff/alex/workspace/vhffs/vhffs-backend »
> > > install-data-hook will not overwrite
> > > existing /etc/vhffs/vhffs.conf make[2]: quittant le répertoire
> > > « /home/staff/alex/workspace/vhffs/vhffs-backend »
> > > make[1]: quittant le répertoire
> > > « /home/staff/alex/workspace/vhffs/vhffs-backend »
> > > 
> > > 
> > > I've also specified a bulk conf-path :
> > > ./configure --with-conf-path=/tmp/v/etc/vhffs
> > > 
> > > 1st time I call make install, it install both vhffs.conf and
> > > vhffs.conf.dist
> > > Here is the install hook transcript :
> > > make  install-data-hook
> > > make[2]: entrant dans le répertoire
> > > « /home/staff/alex/workspace/vhffs/vhffs-backend »
> > > /usr/bin/install -c -m 644 vhffs.conf /tmp/v/etc/vhffs/vhffs.conf
> > > 
> > > 2nd call, it wont let me override vhffs.conf :
> > > make  install-data-hook
> > > make[2]: entrant dans le répertoire
> > > « /home/staff/alex/workspace/vhffs/vhffs-backend »
> > > install-data-hook will not overwrite
> > > existing /tmp/v/etc/vhffs/vhffs.conf
> > > 
> > > 
> > > Pay attention that the .dist is installed each time you call make
> > > install. Installation script will copy the vhffs.conf.dist file to
> > > vhffs.conf *only* if it doesnt exist.
> > > 
> > > If I delete the config file (but not the .dist) it will recreate
> > > it at next make install.
> > > 
> > > 
> > 
> > 
> > Duh ! I guess I missed something (maybe I overriden config file
> > previously, I don't know), It seems to work now....
> > I think I'll add the patch this week end.
> > Thanks for your work and patience :)
> > Sébastien
> > 
> > > 
> > > --Alexandre
> > > 
> > > 
> > > 
> 
> Hi
> Found another bug (sorry). Robots use lib path is wrong due to this
> line in Makefile.am :
>     -e 's,'%VHFFS_LIB_DIR%',$(APIDIR),g'
> which should read 
>     -e 's,'%VHFFS_LIB_DIR%',$(VHFFS_LIBDIR),g'
> I still have some tests to do so I let you patch the patch (in case I
> find bugs which I'm not able to correct)
> Regards
> Sébastien


I applied your patch to trunk with this correction since it seems to be
stable enough. We'll see if it was a good choice ;)

Attachment: signature.asc
Description: PGP signature