| Re: [hatari-devel] Hatari screen dialog regression |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx, andreas_g86@xxxxxxxxxx
- Subject: Re: [hatari-devel] Hatari screen dialog regression
- From: Eero Tamminen <oak@xxxxxxxxxxxxxx>
- Date: Wed, 13 Aug 2025 22:21:46 +0300
- Dkim-filter: OpenDKIM Filter v2.11.0 smtp.dnamail.fi DB7BE4098E85
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=helsinkinet.fi; s=2025-03; t=1755112906; bh=3DcWQxsgOrlWEpHQHaKTSnYU37lxL86InVMnh0qNN00=; h=Date:Subject:To:References:From:In-Reply-To:From; b=RgSqC5m9htTcUToImEW/UjKJxHZO6MLH5h3gJWN2fOEQTiLA/4GCr8g57lctidm6e g8U+ZF/7+CXFMWMF4dVRr2lgBGNkm/x1nAQnyBv1qDejdIspyCGauuHMUI2HfCdDV+ HD+4NqKS9RP1FsrDHQme/lzUmh1DehsHY9axctZ9mSKlJ++nLD9hg3hnYTb95RHK7f UQO/Q6QjKhMmz7ZXIpFmD73PWp/jgV6wNnzFXBqjquEdBrsQaUlCpPx0NDepGEfV+m gg2wKixvzawX5z7JtTsSsmr/7mtfrgXMIqS60vjApp9CHbiaKd2u2w/NXHcxdm+WcM qE894KT0YAvVA==
Hi Andreas,
On 13.8.2025 7.02, Andreas Grabher wrote:
Am 13.08.2025 um 02:12 schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
There has already been a window size check in SDLGui_DoDialogExt():
if (pSdlGuiScrn->h / sdlgui_fontheight < dlg[0].h)
{
Log_Printf(LOG_ERROR, "Screen size too small for dialog!\n");
return SDLGUI_ERROR;
}
Why are we adding another (portability breaking) check?
To verify that dialog works also with users' configurations...
The existing one works and is portable by using the actual window size instead of hard coding some values.
....not just with your current configuration.
It's clearly needed because all 3 of us Hatari developers got it wrong
and merged broken code twice (after testing).
Doesn't Previous have user configuration options that affect its window
size?
- Eero