| Re: [hatari-devel] Hatari screen dialog regression |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx, Eero Tamminen <oak@xxxxxxxxxxxxxx>
- Subject: Re: [hatari-devel] Hatari screen dialog regression
- From: Andreas Grabher <andreas_g86@xxxxxxxxxx>
- Date: Wed, 13 Aug 2025 06:02:24 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; bh=UgyK4sbLQACx9PhFL7Ctu9qlTancgxTEG/ILq+XAGFo=; h=Content-Type:From:Mime-Version:Subject:Date:Message-Id:To:x-icloud-hme; b=Qu3UdiFiIMILUz1G9bkSHt2l4bEF1F9x0zqIxbRfcppShYF2ht1O9uqL30vhU3JdkACKfQ2MosZ5+dbcHD+BsKGWnot/SkOToAwJxo6FUsOsoShNIcrAmNVqmlPAgOtecCdcylYjO8PYJzxc1ZmYGKSlkUESLc8FS+kb5jVwbp+NeE/uNrb9xZi/54rJif0QCKmvRTWrwAN5loz2WsGDR3KbFsfxeCSX+Ll4ScEJG7CY7iB7jxfjayZxsZXsBpcxodTVtpVnrfVGK5+povTUsS34q4m2vrTCjw0GeDWbbZyrOp2ZzAH4zebdBhJ+W7b5rHq8OcR+23NafmZqrJaeBg==
Von meinem iPhone gesendet
> Am 13.08.2025 um 02:12 schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
>
> Hi,
>
>> On 12.8.2025 22.51, Thomas Huth wrote:
>> Am Mon, 11 Aug 2025 02:33:05 +0300
>> schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
>>> IMHO "Recording" (audio, video & screenshots) should be its own dialog,
>>> which would also leave space for improving the current "Hatari screen"
>>> layout.
>> Maybe yes ... but then we also need to figure out another layout for the
>> main dialog again...
>>> I think it would be too much GUI/code refactoring (needs main dialog
>>> layout change too etc) to be done before 2.6.1 release though.
>> Full ack. I think your current patch is fine for 2.6.1, could you commit it?
>
> Pushed (with updated documentation).
>
> I don't think there are any release blockers left?
>
>
> - Eero
>
> PS. I have already started working on some items that will go in after release is done:
> * Fixes for several virtual INF file deficiencies around "--tos-res"
> * Generalized autostart attribute for all relevant Hatari options
> * Splitting Recording related items to its own GUI dialog (no started)
>
There has already been a window size check in SDLGui_DoDialogExt():
if (pSdlGuiScrn->h / sdlgui_fontheight < dlg[0].h)
{
Log_Printf(LOG_ERROR, "Screen size too small for dialog!\n");
return SDLGUI_ERROR;
}
Why are we adding another (portability breaking) check? The existing one works and is portable by using the actual window size instead of hard coding some values.