| Re: [hatari-devel] Hatari screen dialog regression |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] Hatari screen dialog regression
- From: Andreas Grabher <andreas_g86@xxxxxxxxxx>
- Date: Wed, 13 Aug 2025 21:24:55 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; bh=PHqCrqfQ/yb3vLKcjqy//QZx6dqmVG+ggPvjoc3mklQ=; h=Content-Type:From:Mime-Version:Subject:Date:Message-Id:To:x-icloud-hme; b=KsIJ4jjVrm/ktq0AJvzw57xs+7NgwwGHH4XBwxQF/Prj4jN9xXJGRUnHaLTLwvfLmGit6PwGzZxgDo1x4ujGQWkh/ZWiyiR990QfqHM6mtYxkjJhwfVZYo3wLtlmBD/JU6L5Oop8TwohRE9CvtL3LYIBzRzRCbzCQ59+E2qR0f9jLUP5CFF5r4j+2lCYC6d87ez5wgiVpPjMWiQv+lMl11e58bh+cdfB2GosJUCzmZ3fgZ4qm5/WqTyWieSlwWjpVlzqpcJnI8+wHUbn5NhijV0oRpi8AbXaINBkY4JDPAmsU2Rd6RvccOzdOzZ4WkeYS2ND+Xpj0PaQ++OXlhctjQ==
> Am 13.08.2025 um 21:21 schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
>
> Hi Andreas,
>
> On 13.8.2025 7.02, Andreas Grabher wrote:
>>>> Am 13.08.2025 um 02:12 schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
>>> There has already been a window size check in SDLGui_DoDialogExt():
>>> if (pSdlGuiScrn->h / sdlgui_fontheight < dlg[0].h)
>>> {
>>> Log_Printf(LOG_ERROR, "Screen size too small for dialog!\n");
>>> return SDLGUI_ERROR;
>>> }
>>> Why are we adding another (portability breaking) check?
>>
>> To verify that dialog works also with users' configurations...
>>
>> The existing one works and is portable by using the actual window size instead of hard coding some values.
>
> ...not just with your current configuration.
>
> It's clearly needed because all 3 of us Hatari developers got it wrong and merged broken code twice (after testing).
>
> Doesn't Previous have user configuration options that affect its window size?
>
It has not. If it had I would test my code with the smallest possible window size. This is not a runtime issue but a coding issue.
> - Eero
>
>
>