Re: [hatari-devel] -fno-common for macOS

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi,

On 29.7.2025 15.36, Andreas Grabher wrote:
> I am forwarding this in case you didn’t receive it from the mailing list.

Did not receive it, but I see the updated patch in the ML archive (I 
assume you've tested it?):
https://listengine.tuxfamily.org/lists.tuxfamily.org/hatari-devel/2025/07/msg00122.html

Loooks good to me now!


Thomas?

	- Eero

> Andreas
>
> > Anfang der weitergeleiteten Nachricht:
> >
> > Von: Andreas Grabher <andreas_g86@xxxxxxxxxx>
> > Betreff: Aw: [hatari-devel] -fno-common for macOS
> > Datum: 28. Juli 2025 um 13:26:37 MESZ
> > An: hatari-devel@xxxxxxxxxxxxxxxxxxx
> > Antwort an: hatari-devel@xxxxxxxxxxxxxxxxxxx
> >
> >
> >
> > > Am 28.07.2025 um 10:39 schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
> > >
> > > Hi Andreas,
> > >
> > > On 21.7.2025 12.45, Andreas Grabher wrote:
> > > > it seems the latest compilers on macOS require -fno-common to be set in order to avoid a compilation error (ld: warning: reducing alignment of section __DATA,__common from 0x8000 to 0x4000 because it exceeds segment maximum alignment).
> > > > Here is a post about the issue: https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2025-May/343169.html
> > > > At the moment -fno-common is only set if ASAN is enabled but it should always be set.
> > >
> > > I did not receive rest of the discussion, but saw it on the mailing list archive.
> > >
> > > In your patch proposal, I think it would make more sense to use temporary local allocations instead of static object-global ones.
> > >
> > > (Either in stack, or alloc & free from heap.)
> > >
> > >
> > > 	- Eero
> > Thank you for the review! This is a good suggestion. I modified the patch accordingly.
>