Re: [hatari-devel] Minor CMake cleanup

Am 09.11.2024 um 08:25 schrieb Thomas Huth <th.huth@xxxxxxxxx>:

Am Sat, 2 Nov 2024 10:52:50 +0100
schrieb Andreas Grabher <andreas_g86@xxxxxxxxxx>:

Am 02.11.2024 um 08:16 schrieb Thomas Huth <th.huth@xxxxxxxxx>:

Am Fri, 1 Nov 2024 11:24:40 +0100
schrieb Andreas Grabher <andreas_g86@xxxxxxxxxx>:

I have another minor patch here. It removes some code that seems to be unused.

Thanks, but the patch seems to be incomplete: There are some more lines
that use ${FRAMEWORKS} in the main CMakeLists.txt file. I wonder what this
was all about - can't remember ... maybe it was meant to provide the
possibility to add additional frameworks to the Hatari.app via this
variable?

Good question! At least removing it has no immediate effect. Maybe the one who added it remembers what this was meant for before we remove it. If we decide to remove, the appended patch should be fine (including some other residues that seem to be unnecessary).

According to the git history, it was me who committed it, but I really
don't remember what this was all about. Likely just a copy-n-paste from
some other Mac OS X project.

So I applied your patch now, let's see if anybody complains. (but I kept
the CMAKE_XCODE_ATTRIBUTE_LD_RUNPATH_SEARCH_PATHS line since it looks like
it could still have a meaning).

Thomas

It seems that CMAKE_XCODE_ATTRIBUTE_LD_RUNPATH_SEARCH_PATHS was added by Troed together with lots of other lines that are no longer here: https://listengine.tuxfamily.org/lists.tuxfamily.org/hatari-devel/2023/04/msg00046.html

I did not find very much about that attribute. There is a discussion here: https://cmake.org/pipermail/cmake/2013-February/053626.html

Removing the line does not have an effect on Previous. Probably these lines in src/CMakeLists.txt make it obsolete:

set_target_properties(${APP_NAME} PROPERTIES INSTALL_RPATH

"@executable_path/../Frameworks")

set_target_properties(${APP_NAME} PROPERTIES BUILD_WITH_INSTALL_RPATH TRUE)

Regards,

Andreas