| Re: [hatari-devel] Minor CMake cleanup |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] Minor CMake cleanup
- From: Thomas Huth <th.huth@xxxxxxxxx>
- Date: Sat, 9 Nov 2024 07:25:06 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1731137108; bh=L9UWvMbt8nz0IVE3q29u+CyccnZFWqdFcPmDIGqr5Cs=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=Ftmk1H1/UQL6ldsn651NuFY8c8akzaKsjBI+lXg4eSoQ883zul9djzOUn3+M4OBAB Z0n0CPLIQfcO+gN1BkCrHbtm9HlrMiqLycwRXEk510LJhXyjl8tsmyeEGzWyNQOSrc tqap4rrd1ytCPYYVua5f0esbBZb6/qhexEH3cEPTor/oqU1UrDgCO4XsmNNqdSpDtY mHPXmpIfJs/My+8VB3orDF1ygjstXzVbmmfxr67tgzASXsiN5R3jJew340l7rZlxxD TuC1BE0C6sHmh2dbj2dGMaP0+eb8vQJrLuZXlHh30Sj3a0pTVBLY+Od9tKxVpuyTbz qaOczDq1uINxQ==
Am Sat, 2 Nov 2024 10:52:50 +0100
schrieb Andreas Grabher <andreas_g86@xxxxxxxxxx>:
> > Am 02.11.2024 um 08:16 schrieb Thomas Huth <th.huth@xxxxxxxxx>:
> >
> > Am Fri, 1 Nov 2024 11:24:40 +0100
> > schrieb Andreas Grabher <andreas_g86@xxxxxxxxxx>:
> >
> >> I have another minor patch here. It removes some code that seems to be unused.
> >
> > Thanks, but the patch seems to be incomplete: There are some more lines
> > that use ${FRAMEWORKS} in the main CMakeLists.txt file. I wonder what this
> > was all about - can't remember ... maybe it was meant to provide the
> > possibility to add additional frameworks to the Hatari.app via this
> > variable?
>
> Good question! At least removing it has no immediate effect. Maybe the one who added it remembers what this was meant for before we remove it. If we decide to remove, the appended patch should be fine (including some other residues that seem to be unnecessary).
According to the git history, it was me who committed it, but I really
don't remember what this was all about. Likely just a copy-n-paste from
some other Mac OS X project.
So I applied your patch now, let's see if anybody complains. (but I kept
the CMAKE_XCODE_ATTRIBUTE_LD_RUNPATH_SEARCH_PATHS line since it looks like
it could still have a meaning).
Thomas