Re: [hatari-devel] Minor CMake cleanup

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi,

On 2.11.2024 9.16, Thomas Huth wrote:
> Am Fri, 1 Nov 2024 11:24:40 +0100
> schrieb Andreas Grabher <andreas_g86@xxxxxxxxxx>:
>
> > I have another minor patch here. It removes some code that seems to be unused.
>
> Thanks, but the patch seems to be incomplete: There are some more lines
> that use ${FRAMEWORKS} in the main CMakeLists.txt file. I wonder what this
> was all about - can't remember ... maybe it was meant to provide the
> possibility to add additional frameworks to the Hatari.app via this
> variable?

"git blame" shows you adding that variable to CMakeLists.txt in 2015:
https://git.tuxfamily.org/hatari/hatari.git/commit/?id=51812208ebd44d6a7d591f52b6732767d9bb3afb

And to src/CMakeLists.txt year later:
https://git.tuxfamily.org/hatari/hatari.git/commit/?id=6a26454994a56c38d4732e0497fcd0fefb24601f

=> Latter commit mentions Jerome, so maybe he knows more?


(After that there's only the commit from last year:
https://git.tuxfamily.org/hatari/hatari.git/commit/?id=742a83062e05e9ca38ed15f0fbfcc53fbb44ec85)


	- Eero