| Re: [hatari-devel] Remove C++-style comments |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: Andreas Grabher <andreas_g86@xxxxxxxxxx>
- Subject: Re: [hatari-devel] Remove C++-style comments
- From: Thomas Huth <th.huth@xxxxxxxxx>
- Date: Sun, 3 Nov 2024 19:44:25 +0000
- Cc: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1730663067; bh=h0AaxOVy+0IuXnmCyen5g48I9osYh70uWJ+WgcSTyBk=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=kYJujRuwXZbavjhXJugNKnVghFjQbyEXwQ2Q5fEkDfiRpV3anrfPcoou4iIqwZ9kv N4e9HvavHLW6S+CJ7bNUHzoIc+Y5prU+kLZ1kbnqsTkQAT3LWLIgUY/uFwNtYklLRd Kgrptl4OcTKkGRXd8GAUtA2ziBKuo9akB9r0laPvL3rj3N4S2+hl/hAhgN8xNpHP/b GC5XkCi8d/HQSNYBcMZmYaPSwqfHpVYACi8+3CX3pJ0yK6udwSOyYLvF7+uvIs/7/o P4NpFcUT+LQsGK+dR5t8boa4O+Nh+sVawn5/RWFyPdLmeREG5xpo8Z63UGoIoxVWvX h3ukIKFtsW/7Q==
Am Sun, 3 Nov 2024 20:21:52 +0100
schrieb Andreas Grabher <andreas_g86@xxxxxxxxxx>:
> > Am 03.11.2024 um 18:41 schrieb Thomas Huth <th.huth@xxxxxxxxx>:
> >
> > Am Sun, 3 Nov 2024 18:03:15 +0100
> > schrieb Vincent Rivière <vincent.riviere@xxxxxxxxxxx>:
> >
> >>> On 03/11/2024 at 13:17, Thomas Huth wrote:
> >>> Honestly, I'm not sure whether we should really enforce the comment markers
> >>> in Hatari like this. Using "/* ... */" was important 20 - 30 years ago when
> >>> not all C compileres were able to deal with "//" comments yet, but these
> >>> times are clearly over.
> >>
> >> Well, it's just a matter of standard.
> >>
> >> - If you decide that Hatari is written in C89, then you must forbid //
> >> comments, as they aren't part of the standard.
> >>
> >> - But if you decide that Hatari is written in C99, then you should allow //
> >> comments, as they are part of the standard. Except if you want to ban //
> >> comments for some other reason. Every project has his own rules.
> >
> > Hatari uses -std=gnu99. And we don't recommend anything in the coding
> > styles, so both ways of comments should be fine. Thus let's really keep the
> > comments the way that they currently are.
> >
> > Thomas
> >
> Well, I don‘t know what‘s the problem with cleaning this up, especially for single // like in the DSP code (only one // in all files).
It's unnecessary code churn, e.g. making your life more difficult when
using "git blame" later for example.
I'm fine with changing the comments in individual files if it helps keeping
the differences between Hatari and Previous smaller (e.g. in the dsp code),
but I don't see the point in changing this globally just for the sake of it.
Thomas