Re: [hatari-devel] Warnings and notes when building Hatari locally on macOS

[ Thread Index | Date Index | More lists.tuxfamily.org/hatari-devel Archives ]


Am Mon, 19 Feb 2024 18:10:13 +0100
schrieb Frank Danapfel <frank.danapfel@xxxxxxxxxxxxxx>:

> Hello,
> 
> when building Hatari locally using the latest sources from https://github.com/hatari/hatari.git it generates the following warnings when running cmake --build . :
> 
> /Source/hatari/src/cpu/gencpu.c:2860:27: warning: variable 'ws' set but not used [-Wunused-but-set-variable]
>         int h = 0, t = 0, c = 0, ws = 0;
>                                  ^
> 1 warning generated.

Hmm, this one occurs on Linux, too, when using Clang for compilation
instead of GCC... maybe the "ws" stuff could simply be removed since
it is not used at all? CC:-ing Toni ...

> /Source/hatari/src/gui-osx/SDLMain.m:460:21: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
> static int IsRootCwd()
>                     ^
>                      void
> /Source/hatari/src/gui-osx/SDLMain.m:467:33: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
> static int IsTenPointNineOrLater()
>                                 ^
>                                  void

These two should be easy to fix, just by adding a "void" in the
parantheses. Done now.

For the remaining warnings, I think we need a macos developer, like Nicolas
already said.

 Thomas



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/