Re: [hatari-devel] Warnings and notes when building Hatari locally on ma

On 19. Feb 2024, at 21:54, Nicolas Pomarède <npomarede@xxxxxxxxxxxx> wrote:

Le 19/02/2024 à 18:10, Frank Danapfel a écrit :
Hello,
when building Hatari locally using the latest sources from https://github.com/hatari/hatari.gitit generates the following warnings when running cmake --build . :
/Source/hatari/src/cpu/gencpu.c:2860:27: warning: variable 'ws' set but not used [-Wunused-but-set-variable]
  int h = 0, t = 0, c = 0, ws = 0;
     ^
1 warning generated.
/Source/hatari/src/gui-osx/SDLMain.m:460:21: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
static int IsRootCwd()
  ^
     void
/Source/hatari/src/gui-osx/SDLMain.m:467:33: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
static int IsTenPointNineOrLater()
  ^
     void
/hatari/src/gui-osx/SDLMain.m:515:41: warning: cast from 'char **' to 'const char **' must have all intermediate pointers const qualified to be safe [-Wcast-qual]
  NSApplicationMain (argc, (const char**)argv);
     ^
3 warnings generated.
There are also lots of „notes“ related to SDL which weren’t there in previous builds:
Compiling /Source/hatari/src/gui-osx/en.lproj/SDLMain.xib

hi

thanks for the report.

regarding the unused 'ws' variable, it's part of a commented block that might be enabled later in WinUAE, so it's better to keep it this way.

as for the other warnings, it would need someone with macOS to provide a .diff for these, as "main" developpers don't use macOS which makes it difficult to test the changes (especially those in .xib files seem to be all the same, but we need someone to fix/test the result)

maybe you can have a look if you know macOS coding ?

Nicolas