| Re: [hatari-devel] savestate_fname in custom.c? |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] savestate_fname in custom.c?
- From: Thomas Huth <th.huth@xxxxxxxxx>
- Date: Fri, 22 Dec 2023 06:19:04 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1703225946; bh=tPPg5Kr0nyVn/gWhJWILM7hh4xnRIG3zgO7uAWEEHow=; h=Date:From:To:Subject:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=MsGp09IEi6cySxjaDkv6jdqpuSt3X/YICAz/uU00JLzSqDmm+Emh9mz9Eh9Zm19P5 E3qU4REO00F/CaBPzziBEzOECmMOKZ7cAvCCvmFqKGpDkmZf4Q4+DXhXOUubn2kuqW uDE5ZXIlzBfyZp0gzmkEccUX0nlg3XiIZNkdelPhif2DbxRtLc7xZkXqPrw1M2I3+I vbStpfdpbDoV7yI1AmjsVBl5GbGKNM3Bpv8guBvJ5DjZiIsNrzI331dQXOiDkhzWfz /H3uC9xZ3hv8zIirNDOULYOIPbgbV+XjVHtUwMHRcYi/+BpdujPJAs8vyBvwJf4coo KOlri1M6oHw3w==
Am Fri, 22 Dec 2023 00:56:02 +0200
schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
> Hi Thomas,
>
> You changed "savestate_fname" declaration in "custom.c" to fix LTO error.
>
> It seems to be declared already in "savestate.h". Why "custom.c" is not
> including that?
>
> (Or why "savestate_fname" is declared in "savestate.h" instead of in
> "custom.h"?)
The savestate_fname line in savestate.h comes from WinUAE, so that's where
this extern declaration belongs to. The variable itself is declared in a
file called savestate.cpp - which we don't have in Hatari, so I assume it
has been added to custom.c to make it compile on the Hatari side without
the need to copy the full savestate.c file over.
Looking at the original custom.cpp in WinUAE, I can see that it also does
#include "savestate.h", so I think it's fine if we add that line to our
version in Hatari, too.
Thomas