Re: [hatari-devel] savestate_fname in custom.c?

[Andreas Grabher <andreas_g86@xxxxxxxxxx>]

> Am 22.12.2023 um 07:19 schrieb Thomas Huth <th.huth@xxxxxxxxx>:
> 
> Am Fri, 22 Dec 2023 00:56:02 +0200
> schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
> 
>> Hi Thomas,
>> 
>> You changed "savestate_fname" declaration in "custom.c" to fix LTO error.
>> 
>> It seems to be declared already in "savestate.h".  Why "custom.c" is not 
>> including that?
>> 
>> (Or why "savestate_fname" is declared in "savestate.h" instead of in 
>> "custom.h"?)
> 
> The savestate_fname line in savestate.h comes from WinUAE, so that's where
> this extern declaration belongs to. The variable itself is declared in a
> file called savestate.cpp - which we don't have in Hatari, so I assume it
> has been added to custom.c to make it compile on the Hatari side without
> the need to copy the full savestate.c file over.
> 
> Looking at the original custom.cpp in WinUAE, I can see that it also does
> #include "savestate.h", so I think it's fine if we add that line to our
> version in Hatari, too.
> 
> Thomas
> 
I see that you are cleaning some code right now. May I suggest this very minor cosmetic change (patch appended)?

Attachment: cpu.diff
Description: Binary data