| Re: [hatari-devel] DSP issue on M1 Mac (not happening on x86_64) |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] DSP issue on M1 Mac (not happening on x86_64)
- From: Andreas Grabher <andreas_g86@xxxxxxxxxx>
- Date: Wed, 28 Dec 2022 16:45:29 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1672242349; bh=BRqP6EjhaRtO8sv4+k5ftRkXGuVJ8n1x4hzvlUmiFOU=; h=From:Content-Type:Mime-Version:Subject:Date:To:Message-Id; b=T3lOe84gh+Q457WmD5qzuOsCvJBNloWHSt1cKf0LG9S0lOBrMJziOw3oOLa28es2f 8FPDJJ34WCfm0GJEMKonSWcxIEPhQRMkUXpgmetBzYtvbphEdvg/skYzEWgnBMZMOE BFu7Ifo1pG29bX3TVIf6abWa0gwSzpDYL/7R0VSX8MukbSyrZbVE5UzcHQ91i7VOmW 4UrWUq6ztvFmwHD9xgRxbChb26OmChSOKt2/Gjfj92nI8DBAcIdX/NLKLNSfWSQET3 I9z5MRvw7rLitnx5lrDq3ZfRcXwHM9JfE+7X4w+/1O0mM86MTIQxvFRrr9rqnVtJz3 GSb7u9zPmO5FA==
OK, I found the problem! It seems this program (as the only one I know) uses a hardware low pass filter. The simulation of this filter is obviously faulty. DSP/Hatari is not affected from this.
Sorry for the trouble.
> Am 28.12.2022 um 15:11 schrieb Laurent Sallafranque <laurent.sallafranque@xxxxxxx>:
>
> Hi,
>
>
> I've also recently encountered a decrease in sound quality with certain falcon musics.
>
> I also believe, like Nicolas, that the problem is related to double precision.
>
> At least, that would be the first step to fix before searching anything else.
>
> Laurent.
>
>
> Le 28/12/2022 à 15:07, Nicolas Pomarède a écrit :
>> Le 28/12/2022 à 15:02, Andreas Grabher a écrit :
>>>
>>>
>>>> Am 28.12.2022 um 14:54 schrieb Nicolas Pomarède <npomarede@xxxxxxxxxxxx>:
>>>>
>>>> Le 28/12/2022 à 14:49, Andreas Grabher a écrit :
>>>>> Hello all,
>>>>> this issue affects Previous, but because Previous shares most of its DSP simulation with Hatari (with minor additions like DMA) it might also affect Hatari. In some DSP music demo I am getting a cracking noise when running on an M1 Mac. Running on an x86_64 Mac there very same demo does not suffer from that noise.
>>>>> Did someone experience a similar issue using Hatari on an M1 Mac? Does someone have an idea where to start searching the bug?
>>>>> Best wishes,
>>>>> Andreas
>>>>
>>>> Hi
>>>>
>>>> can't tell if there're some cracking noises under Hatari recently.
>>>>
>>>> but the DSP / crossbar part uses some floating point variables to mix the different frequencies into the final audio stream. If there's not enough precision this can give bad rounding and artefacts in the sound.
>>>>
>>>> Maybe M1 mac has different precision for float/double ?
>>>>
>>> Only the DSP core is used (dsp_core.c, dsp_cpu.c and dsp_disasm.c). As far as I can tell they do not use any floating point numbers.
>>>
>>
>> indeed, only use of double's is in crossbar.c
>> falcon uses crossbar.c for outputing sound, if next/previous has some different HW that only use the DSP core I'm not sure this can be duplicated.
>>
>> Nicolas
>>
>>
>
>