[hatari-devel] Removing SDL use for byte order checks / conversions

[ Thread Index | Date Index | More lists.tuxfamily.org/hatari-devel Archives ]


Hi Thomas,

I noticed that you recently got rid of SDL dependency for byte order checks / conversions in several files.

Finding remaining (not screen*) files using SDL for that, but not any other SDL functionality:
-------------------------------------------
$ for i in $(git grep -l -e SDL_BYTEORDER -e SDL_Swap | grep -v /screen); do
  echo "*** $i ***";
  grep SDL_ $i | grep -v -e SDL_BYTEORDER -e SDL_Swap -e SDL_endian;
done
*** src/avi_record.c ***
  SDL_Surface	*Surface;
	NeedLock = SDL_MUSTLOCK( pAviParams->Surface );
			SDL_LockSurface ( pAviParams->Surface );
			SDL_UnlockSurface ( pAviParams->Surface );
void Avi_SetSurface(SDL_Surface *surf)
*** src/convert/low320x32.c ***
*** src/convert/low320x32_spec.c ***
*** src/convert/low640x32.c ***
*** src/convert/low640x32_spec.c ***
*** src/convert/med640x32.c ***
*** src/convert/med640x32_spec.c ***
*** src/cpu/sysdeps.h ***
*** src/floppy.c ***
*** src/hdc.c ***
*** src/ide.c ***
*** src/lilo.c ***
*** src/msa.c ***
*** src/netbsd.c ***
*** src/sound.c ***
*** src/spec512.c ***
*** src/tos.c ***
*** src/video.c ***
*** src/wavFormat.c ***
-------------------------------------------

Are you going to convert those too?


Btw. I noticed also this commit:
"dmaSnd.c still needs SDL_stdinc.h for the M_PI constant"

"dmaSnd.c" already includes "main.h", which include <math.h>, which provides M_PI. Why <SDL_stdinc.h> is needed?


	- Eero



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/