Re: [hatari-devel] Hatari Windows 2.4.1 release and PortMidi?

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi,

On 23.8.2022 16.44, Thorsten Otto wrote:
> On Dienstag, 23. August 2022 07:19:52 CEST Christian Zietz wrote:
> > I remember I had huge difficulties building portmidi (the version from
> > the SourceForge in Hatari's doc) from source.
>
> Took a look at the source package from my distro (tumbleweed), which had some
> patches to fix build problems. Also took a look at the fedora packages, which
> has similar patches, and also a patch to disable java bindings. The attached
> patch below is a combination of those, relative to the -217 release.

Thanks!

Half of the patch is updating CMake to drop Java bindings + changing 
fixed install paths to use suitable variable for it.


Another half of the patch is doing code changes like this:
-    printf(prompt);
+    printf("%s",prompt);

Why not replace printf() with puts(), if no formatting is needed?


	- Eero

> With that, you can just use
>
> $ cmake -G "MSYS Makefiles" .
>
>
> and run make. According to some comment in the *.spec files, using a decidated
> build directory does not work (but i did not try that). What's not working is
> to use -G "MingW Makefiles", that complains about sh.exe being in the PATH.