| Re: [hatari-devel] Re: Make building the Python GTK+3 user interface conditional. (PR #21) |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] Re: Make building the Python GTK+3 user interface conditional. (PR #21)
- From: Thomas Huth <th.huth@xxxxxxxxx>
- Date: Mon, 1 Aug 2022 18:14:35 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1659377677; bh=jTt8hm4l+whzzAECVR9ndur6dqtAmtNAxmnvPBZJ5V4=; h=Date:From:To:Subject:From; b=oQ6NLFlj5fk40xgV9HOjJbpzEPeu30/Pmx8+WyAqTMniBa2iwi9Q1wzcWbt/zQ6Bm 9vx+nv/kLqWrLz/L+X5iJsfq5/edMuqCpSagAnEPtNGOAvvpyKG0C4wU216e7DvV1q pYYtYJULpOaHj1DzbDihSUcI7F+QqdL4SVj6/EUzOoOPztVLYDdkZGowraShw1JXRD jiCZWVoKt4horwFSrKOg5TlYno5mBMDDWsxTJsMRt8zmPjmVkLbpi+v2St2tHBduKk 812xgDLGCVoSB1CW35p4g+VSmIBYDJ0jk84H2w9RKbvJmjjzOcR+16fd/m6kh06BVP A1DpgWQDnCOGg==
Am Mon, 1 Aug 2022 18:12:21 +0000
schrieb Thomas Huth <th.huth@xxxxxxxxx>:
> Am Sun, 31 Jul 2022 01:48:29 +0300
> schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
>
> > Hi,
> >
> > On 30.7.2022 9.28, Thomas Huth wrote:
> > > could you please have a look at the PR below, please?
> >
> > I checked the patch.
> >
> > > Sounds basically ok to me, but wouldn't it be better to probe for the
> > > python package instead of introducing a user-selectable switch in the CMake
> > > file?
> >
> > I completely agree.
> >
> > There should be CMake test that checks whether this works instead:
> > ------------
> > #!/usr/bin/python3
> > import gi
> > # use correct version of gtk
> > gi.require_version('Gtk', '3.0')
> > from gi.repository import Gtk
> > from gi.repository import Gdk
> > from gi.repository import GdkPixbuf
> > from gi.repository import GLib
> > ------------
> > (code taken from dialogs.py)
>
> Thanks! ... it was a little bit tricky to get the Python-code into
> CMakeLists.txt, but I think I've now found a way to do it:
>
> https://git.tuxfamily.org/hatari/hatari.git/commit/?id=7464d784485142
>
> Let me know if it does not work as expected.
.... aaaand of course it broke the CI:
https://app.travis-ci.com/github/hatari/hatari/jobs/578410141
I missed to test the case without a valid Python 3 interpreter ... *sigh*.
Thomas