| Re: [hatari-devel] Preparing for next release 2.4 |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] Preparing for next release 2.4
- From: Thomas Huth <th.huth@xxxxxxxxx>
- Date: Sun, 10 Jul 2022 11:05:58 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1657451185; bh=jwMcvLV/Qr/+/p40T5UY/mwQ0X90vL0SOQu3EXQ+JhA=; h=Date:From:To:Subject:From; b=iTIxcVdobFR0gZpivCfBQl7hYc7mHmBUTWaMyPIqyg2ktAqCUco5F3a48csjWtvvo fRjdIbfqPxW8OkjKE78iJ49vjcMbyc7XNogzi3U/YrN84xPG52IfRkTsdmoM+PNQXy d8R/fjXzklg3tUuy/8KlKsPgiPkNJIjcI9lwG97Cje/7lmmytrMDEV3iknpxkWXhnR sSlRXpPgTgK8UcdMxsGGXKlrQzT8MfvJIOevW2Voc0rZfdiWtrnCRtuV80VNrvLvdB dKEXqjTvE6jMAH+bwP0ziSkMYMcaMc1VkwdZGLkJEs7rS4FCbWT8i9xZ/l2skK6XJk zpyDzkbo/AlYQ==
Am Sun, 10 Jul 2022 10:46:10 +0000
schrieb Thomas Huth <th.huth@xxxxxxxxx>:
> Am Sat, 09 Jul 2022 18:49:35 +0200
> schrieb Thorsten Otto <admin@xxxxxxxxxxx>:
....
> > I would not consider this being a bug. You'll never know what symbols are
> > defined by header files on not-so-common systems.
>
> Well, that's why system headers normally use the underscore namespace for
> non-standardized identifiers, at least in those files that get included
> automaticall by other headers. If you look at
> https://code.woboq.org/userspace/glibc/sysdeps/unix/sysv/linux/riscv/sys/ucontext.h.html
> you can also see that the used underscores for "union __riscv_mc_fp_state"
> for example.
>
> But it really seems like ucontext.h is claiming the REG_* namespace for its
> public interface, so I guess we should rather convert all REG_* identifiers
> in Hatari to something different instead...
.... or simple avoid including <signal.h> since that seems to be header that
is pulling in <sys/ucontext.h>. The culprit seems to be the #include in
src/cpu/debug.c where we do not really need it, so let's give that a try
first.
Thomas