| Re: [hatari-devel] Preparing for next release 2.4 |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] Preparing for next release 2.4
- From: Thomas Huth <th.huth@xxxxxxxxx>
- Date: Sat, 9 Jul 2022 16:13:53 +0000
- Cc: Tien Hock Loh <tienhock.loh@xxxxxxxxxxxxxxxx>, Teemu Hukkanen <tjhukkan@xxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1657383236; bh=yyVNssmgFTSkN3O/ofEr9AadSmFaAw0/0GasetZUdjE=; h=Date:From:To:Cc:Subject:From; b=Fk4048Tfsd9ZY+W+xSq6R65ZB9XD4LQBZMjlAX8MrNVMaDvv4wwsK8j6zQRH/6Yiz O/WVw7JbsNpjVgjc9Q87WfWfmBIN+M/ePqTCvW1hpiu0MN5yVMQUCxU3WvfiTL8L04 LP3Es8vC5XeKyWoBvtNVqWhqB6C41sVVYKODAeJaU0ychzHjloztHMywXd2sLv8PiH gHCUGGcvJV8dv/AfEPFxFYaY5+P5QT0tDzDfc4hvSDZ8nRGSElfYMMnSnrMgTuKB07 ej+wjvZd5uqJttJs6L7p3mznU+fEiKgObY3fjMH7EKrD8nYq60Wey3FchVxUEU6ZI+ bYY5QU6IZ1hiA==
Am Fri, 1 Jul 2022 17:56:55 +0300
schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
> Hi Teemu,
>
> On 27.6.2022 22.45, Teemu Hukkanen wrote:
> > A small patch has been sent my way for fixing hatari build on RISC-V,
> > the patch is attached.
> > <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1012255>
>
> What RISC-V header is causing the conflict, for which compiler / library
> it is, and why define from such a thing ends in Hatari build?
>
> I mean, if this really is RISC-V specific issue, I'm not sure Hatari is
> the correct place to work around it (e.g. compiler's own defines should
> be prefixed with '_').
I think I agree with Eero - this sounds like it should rather be fixed in
the RISC-V system / libc headers by adding an underscore in front of the
macro there.
We can leave the work-around in Hatari in place for now, but in the long
run, I'd appreciate if someone who's involved with RISC-V could report the
bug there, too.
Thomas