Re: [hatari-devel] (raw) MIDI connection reliability?

[ Thread Index | Date Index | More Archives ]

On 18.6.2022 7.18, Thomas Huth wrote:
Am Fri, 17 Jun 2022 21:51:28 +0300
schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
I added output to MIDI trace on whether buffering disabling actually
succeeded, and fixed issue in
read error handling (it handled other errors than
EOF as valid input).

I don't think that change wrt EOF was really necessary.
Midi_Host_ReadByte() only returns EOF on errors, and that's
also what the comment in front of the function says.

No, it returns what fgetc() returns, or EOF if nothing is available.

Manual page says:
fgetc(), getc(), and getchar() return the character read as an unsigned
       char cast to an int or EOF on end of file *or error*.

(fputc() on the other hand returns only EOF on error.)

	- Eero

Mail converted by MHonArc 2.6.19+