Re: [hatari-devel] Natfeats regression?

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi,

On 16.6.2022 12.37, Matthias Arndt wrote:
> Am Thu, 16 Jun 2022 11:19:36 +0200
> schrieb Christian Zietz <czietz@xxxxxxx>:
> > Matthias Arndt schrieb:
> > > I init the id once and then use this to pass my output.
> > > I used Eero's example code and just added my own wrappers.
> > >
> > > This should be the same as described here:
> > > https://www.atari-forum.com/viewtopic.php?p=293615#p293615
> >
> > Maybe as a workaround/test, you could add a check in your Natfeats
> > print function *not* to call the actual Natfeats handler when the
> > string is empty. But regardless of whether that "fixes" your issue or
> > not, Hatari should not hang when NF_STDERR is invoked with an empty
> > string.
>
> Very interesting, with this workaround it does not crash anymore.

Thanks for verifying!


> I wonder what makes the difference then inside Hatari.
>
> For the time being I'll add this as a patch in my code.

I've fixed it now:
https://git.tuxfamily.org/hatari/hatari.git/commit/?id=272b40ab7052e949d3b40bfd3b3b46318359412a


	- Eero

> > > $ /opt/hatari/bin/hatari-2017-07-19 --debug-except all,autostart -w
> > > --natfeats true -d example_hd/ Native Features enabled.
> > > Video_SetSystemTimings1 2 3
> > > Video_SetSystemTimings2 2 3 -> 4 (STE) 500 500 64
> > > Hatari v2.0.0, compiled on:  Jul 19 2017, 18:30:58
> > >
> > > 5 years or so? ;)
> >
> > Okay, I didn't look so far into the past when checking for changes.
>
> It was the oldest hatari binary I could find that matched approx. the
> time frame of my source code (a combination which should have worked)
>
> Thank your for investigating!
> Matthias