|Re: [hatari-devel] MODE SENSE patch|
[ Thread Index |
| More lists.tuxfamily.org/hatari-devel Archives
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] MODE SENSE patch
- From: Uwe Seimet <Uwe.Seimet@xxxxxxxxx>
- Date: Thu, 17 Mar 2022 21:11:54 +0100
- Authentication-results: strato.com; dkim=none
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1647547914; s=strato-dkim-0002; d=seimet.de; h=In-Reply-To:References:Message-ID:Subject:To:From:Date:Cc:Date:From: Subject:Sender; bh=KAGW/RreW8uYOsgEUnX9BbFcrnY2jyresT539iROXQY=; b=tGkXydfli/tjSw7o+Dn9PRJH3ayGMbcWTwqUUC6dqYhCMtDPEzLeTx5HRnwU1Be8d7 q487WPcq68CcuACBCy0IS/pkUHq0cdvBHr9KmoXOU0QESkSg4Tk4dU8Fm0S88jfcFXCT uZlYQoJAeNVdFLDeHQywW4C6ARBy4MUpxyxwRV6YM0eTQNRQnU/O7ehopJILIU49WF2F eYYWjmmkINKltl6pQ0oqNIZDivkzEny/Un/I7ghl47fICy0sTXj28FY6bmDjwHwv+BIx gHJdZWXMU6FlksUpb8Mno93PoErG9k+DT842t0TFMGT7KW8PBjTRBr/uAyeiBuz9/y9W E35Q==
By the way, maybe the difference between Linux-68K and Intel-Linux is
related to the byte order? Maybe somewhere in the Hatari code SCSI CDB or
result data are swapped on Intel-Linux where they should not be swapped
because they are already in the correct (i.e. big endian = SCSI) byte order.
> > >> Uh, that's a bit involved, as it was from m68k Linux. Quick instructions...
> > >
> > > I'm afraid I am not prepared to spend time on testing on Linux-68k. In this
> > > case I suggest that you simply revert all of my changes.
> > Sorry, I should have been more clear that this was *not* a regression.
> > My reply was about letting people know that your SENSE patch did not
> > resolve that (already known) issue, and the attached output from your
> > "full CDB" patch hopefully providing more info, in case somebody will
> > look at implementing what Linux expects.
> I see :). I indeed thought you were talking about a regression. Without
> knowing the details when looking at the code that displays this message I
> would have expected the message to be independent of the OS (i.e. Intel or
> 68K Linux). You should consider extending the error message so that it
> display the number of bytes returned, e.g.
> Log_Printf(LOG_WARN, "HDC: *** Strange REQUEST SENSE: %d bytes ***!\n"i,
> This may help with analyzing the problem.
> Best regards