Re: [hatari-devel] Valid memory amount?

[Thomas Huth <th.huth@xxxxxxxxx>]

Am Thu, 19 Nov 2020 12:12:40 +0200
schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:

> Hi,
> 
> On 11/19/20 10:48 AM, Nicolas Pomarède wrote:
> > Le 18/11/2020 à 23:49, Eero Tamminen a écrit :  
> >>>> Btw. 10MB is supported on MegaSTE & TT, but
> >>>> not on Falcon.  Specific memory amounts are
> >>>> enforced (with a warning) only for Falcon though.
> >>>> I wonder should they be enforced also for others?  
> >>>
> >>> I assume you are talking about the STMemory_CorrectSTRamSize()
> >>> function? ... I guess yes, maybe it should be enforced for these
> >>> machines, too, but that's certainly a change that should rather
> >>> wait until the release has been done.  
> >>
> >> Would the attached patch be acceptable before release?  
> > 
> > no please, not so close to release, I don't consider this a
> > regression ; RAM amount might not be correct for all possible
> > machine (or not ?), but we're not sure and it's not the time to
> > change it again.  
> 
> It only changes memory handling for Falcon, by
> rounding up also smaller memory amounts to
> something that is actually supported.  Rest is
> just making the memory limit code more readable /
> documented.

No, really, no. We've had enough regressions recently, so please no
more patches like this at this point in time. Even if it seems trivial
for you, the patch isn't that small, and could still introduce new
problems that we certainly don't want at this point in time.

 Thanks,
  Thomas