Re: [hatari-devel] [REGRESSION] Access to non-existant IDE slave crashes Hatari

[Thomas Huth <th.huth@xxxxxxxxx>]

Am Tue, 17 Nov 2020 10:59:07 +0100
schrieb Christian Zietz <czietz@xxxxxxx>:

> Thomas Huth schrieb:
> 
> > I gave this a very quick try, but I was not able to reproduce the
> > crash. Which machine type did you use? Did you use the GUI or the
> > CLI to configure the IDE drive? Fast-boot enabled or disabled?
> > Please provide exact steps how you ran Hatari.  
> 
> Please find attached my configuration file and everything else that is
> needed to reproduce the crash. 

Thanks a lot, with that I was able to reproduce the crash immediately.

> I still believe that any reports of critical regressions (and crashing
> Hatari from a TOS program imho is such) should be investigated by more
> than "a very quick try".

Sorry, that "very quick try" was not meant in the sense that I don't
take your report seriously, but simply in the sense that I currently
have very limited spare time, so I just had some few spare minutes
between waking up, preparing the breakfast for one kid, getting the
other one to the daycare center and then drowning again in my normal
daily work...

> Further debugging Hatari's code shows the precise crash location to be
> in ide_data_readw(), caused by the fact that s->data_ptr is NULL for
> the (non-existant) slave device.

Right. I've added now some sanity checks, so the problem should be gone
now!

> At least a lot of third-party IDE interfaces allow register access in
> user mode, as well. Furthermore, the STBook was the other Atari with
> built-in IDE. It becomes apparent from the STBook schematic that IDE
> register access is possible there in either supervisor or user mode.
> Hence, I wouldn't be surprised if Atari kept it that way for the
> Falcon.

Thanks, I've now added a comment to the code so that we don't have to
raise this question again in a couple of years :-)

 Thomas