Re: [hatari-devel] Linux started to init in Hatari

[ Thread Index | Date Index | More Archives ]


On 3/30/19 1:13 PM, Nicolas Pomarède wrote:
Le 29/03/2019 à 00:46, Eero Tamminen a écrit :
I've pushed this.  IMHO I've provided pretty good / easy step-by-step
instructions now for building & testing Linux under Hatari.

I get a small warning here :

/home/npomarede/src/hatari.wua/src/lilo.c: In function 'lilo_load':
/home/npomarede/src/hatari.wua/src/lilo.c:375:20: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     char *cmd[] = { "symbols", symbols_s, offstr, NULL };

This is with recent gcc 8.3.1

There isn't easy way to fix it.  Literal strings are const char *,
but debugger functions take char* array, so "cmd" above needs to
be char* array too.

Fixing it would require:
* going through implementations for all functionality user can
  invoke from the debugger command line, and changing everything
  modifying strings in the argument array to use strdup & free
  on them instead
* change command string array to const and fix all warnings
  in debugger code coming out of that

Before I can change "cmd" to const char*.

I could look into that at some point, but I would prefer handling
the functionality issues I've noticed before this cosmetic issue.

	- Eero

Mail converted by MHonArc 2.6.19+