Re: [hatari-devel] Screenshots are saved in Hatari installation directory

[Troed Sångberg <troed@xxxxxxxxxxx>]

Hi Anders,

Thanks for testing :)

There is a known bug in that test version, it will not advance grab0001 -> grab0002 etc. I hadn't switched out all calls to getworkingdir, now done. 

If it works for Bob with modified location preference I'll submit it as a patch. It was ... interesting, mixing C and Objective-C. Nicolas will have to scold me if my solution isn't clean enough ;)

regards,
Troed​
​

-------- Original Message --------
 On February 16, 2018 10:43 PM, Anders Eriksson <ae@xxxxxx> wrote:

>
>
> Hi!
>
> I've tested this new macOS fix and it appears to work correctly, thanks!
> It was a bit messy before screenshots, landed everywhere because I
> sometime start Hatari with scripts, sometime not. More than often I just
> took the macOS window-screenshot instead :)
>
> Screen dump saved to: /Users/ae/Desktop/grab0001.png
>
>
> And sorry I wasn't quick enough to test the release candidate build before
> it was released, but it appears to work fine on my machines which are Mac
> Pro 5.1 with High Sierra and Macbook Pro 15" non-retina with Sierra.
>
> I could try to wake up the old 32-bit 2006 Macbook if really needed too.
>
>
>Anders Eriksson
>ae@xxxxxxxxxx://www.dhs.nu/
>ae@xxxxxxxxxxxxx://www.atari.org/
>
>
>
> On Fri, 16 Feb 2018, Troed Sångberg wrote:
>
>>Hi all,
>>I have implemented this now and I'm testing it. Feel free to test it as well: https://troed.ddns.net/f/aa4c8be49ed14ef38e53/
>>@David - on non-macOS this will not change the existing behaviour at all. On macOS it will either use the standard screenshot directory ~/Desktop or the one the user has selected instead through the official macOS preference plist.
>>It will "break" the existing behaviour of saving screenshots to the Application/ directory on macOS, but that's clearly a bug from a macOS usage point of view and should be fixed instead of relied upon existing bad behaviour.
>>regards,
>> Troed
>>PS: macOS caches the com.apple.screencapture.plist value if you override it and it has meant that my testing is a bit complicated. I don't want to log out and log in all the time .. so testing by others is very helpful.
>> ?
>>-------- Original Message --------
>> On February 16, 2018 9:49 PM, Jérôme Vernet vernet.jerome@xxxxxxxxxx wrote:
>>>Envoyé de mon iPhone
>>>>Le 16 févr. 2018 à 21:10, David Savinkoff dsavnkff@xxxxxxxxx a
>>>> Maybe the path should be in hatari.cfg (then it is configurable).
>>>> Only if the change come from Hatari. I don't want to have to change something in Hatari sources for MacOSX.
>>>> Or only if agreed by everyone.
>>>> And don't break what already works for others.
>>>> I think a user-friendly software package should be customised
>>>> by the packager for a specific platform (customised hatari.cfg).
>>>> No, bad idea. MacOSX specific part, if they exist, should only use MacOSX Default SDK, nothing specific to Mac in Hatari.cfg.
>>>>
>>>
>>
>