Re: [hatari-devel] crash on the osx gui

[Troed Sångberg <troed@xxxxxxxxxxx>]

Hmm.

So currently the released binary runs on 10.9+ but crashes with French ui

And with this patch I could release a new binary that would work on 10.6+, including French UI, but midi untested (to be fair, I assume it works).
​
IMHO I think that choice is easy, and I'll release a new binary when the patch has been merged (if Nicolas agrees of course).

Reading through the change.log* I could also see the utility in doing it on tip instead of backporting to the release revisions. That solves the wrong order of load config buttons as well, with no other major visible changes.

I do think many of these issues should have been found and fixed before release. I screwed up the DMG and not testing the Macports library compatibility myself, but the UI issues have been in the nightly builds for quite some time. Maybe there needs to be a release candidate built that we all try to test next time?

regards,
Troed

​*) full current change.log delta from v2.1.0 tagged revision:

changeset:   6865:34632011c523
tag:         tip
user:        Nicolas Pomarede
date:        Mon Feb 12 11:13:10 2018 +0100
summary:     Fix inverted buttons "reset" and "don't reset" on macOS

changeset:   6864:037c938470f8
tag:         tip
user:        Nicolas Pomarede
date:        Sun Feb 11 18:53:24 2018 +0100
summary:     Add more comments to remove warnings when compiling with -Wimplicit-fallthrough=1

changeset:   6863:21bc2b0ebae4
user:        Nicolas Pomarede
date:        Sun Feb 11 17:18:52 2018 +0100
summary:     Add constant NSAlertStyleInformational for older macOS 10.11 (patch by Benoit Tuduri)

changeset:   6862:02cd941037cb
user:        Nicolas Pomarede
date:        Sun Feb 11 14:13:39 2018 +0100
summary:     FindReadline.cmake requires stdio.h when using readline.h for mingw

changeset:   6861:b58db2eee426
user:        Nicolas Pomarede
date:        Sun Feb 11 13:01:11 2018 +0100
summary:     Use CheckSymbolExists instead of check_function_exists in Cmake (patch by Troed Sangberg)

changeset:   6860:c5bfa8773600
user:        Thomas Huth
date:        Sun Feb 11 09:43:43 2018 +0100
summary:     Add "/* fall through */" comments for compiling with -Wimplicit-fallthrough

changeset:   6859:d539755afcba
user:        Thomas Huth
date:        Sun Feb 11 09:40:55 2018 +0100
summary:     Add missing break in GemDOS_OpCode tracing code

changeset:   6858:ac09db060154
user:        Thomas Huth
date:        Sun Feb 11 08:42:27 2018 +0100
summary:     Silence compiler warning with libedit's rl_readline_name

changeset:   6857:4f3103c460bf
user:        Thomas Huth
date:        Sun Feb 11 08:03:03 2018 +0100
summary:     Re-initialize sdlscrn variable before calling SDL_UpdateRect()

changeset:   6856:36c57e5dbb13
user:        Eero Tamminen <oak@xxxxxxxxxxxxxx>
date:        Sun Feb 11 01:10:50 2018 +0200
summary:     Fix CPU/DSP profile "addresses" commands paging

changeset:   6855:ca11115329df
tag:         tip
user:        Eero Tamminen <oak@xxxxxxxxxxxxxx>
date:        Thu Feb 08 00:11:25 2018 +0200
summary:     Minor updates to emutos.txt


-------- Original Message --------
 On February 14, 2018 7:06 PM, Jerome Vernet <vernet.jerome@xxxxxxxxxx> wrote:

>Le 14/02/2018 à 18:41, Troed Sångberg a écrit :
>>​Is this problem in the v2.1.0 release also then, or did I misunderstand that they were missing there as well?
>>Yes, it's in 2.1.0 too. It's not related to your library, only in
> french.lproj.
>
> I can't test midi, no midi output/input here. I built a Framework of
> portmidi instead a library, but cannot test it too.
>
>
> JV
>>(I'm still waiting for someone to test the 10.6+ portmidi library I built and will then update the release build anyway .. )
>>/Troed