| Re: [hatari-devel] New option --disable-video and --benchmark |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
On 02/24/2017 12:03 AM, Nicolas Pomarède wrote:
Le 23/02/2017 à 21:22, Eero Tamminen a écrit :
On 02/23/2017 08:16 PM, Nicolas Pomarède wrote:
As it's now, I'd rather remove the config file support,
as a potential source of user bug reports (when it gets
enabled & saved there by accident).
I'm lost, which config file option are you talking about ?
--disable-video is not saved to the config file (on purpose)
Sorry, my mistake. I somehow though that as you added it
to ConfigureParams (unlike benchmark setting), it would
be also saved to config file. I think everything else
in ConfigureParams is saved to Hatari config file.
>>> --disable-video : don't refresh the screen during emulation. Emulated
>>> screen is still updated into Hatari's internal buffer, but the
result is
>>> never displayed on screen through SDL calls.
>>
>> You've documented the option as:
>> --disable-video <bool> Run emulation without displaying video
>>
>> For consistency with other options, I think it should be either:
>> --disable-video
>> or
>> --video <bool>
>
> I thought about this, but --video sounded too generic to me, but why
> not, I have no opinion on this.
I would actually prefer --disable-video.
Why not just alias it to fast-forward option instead of
duplicating code?
Or do you see some potential problem with fast-forward as that
has also a config file option, user shortcut key, takes audio
buffering into account, and its value is shown in statusbar?
I see fast forward as on option you can toggle on/off during emulation,
as it is now --benchmark does the same as fast forward, but in the
future some more options could be implied by --benchmark, so I'd rather
separate it from the beginning (code duplication is just 2 "if" for now
anyway)
With Thomas' SDL env var trick, yes. :-)
- Eero