| Re: [hatari-devel] --force-max not working in 2.0.0 |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
Hi,
On 11/30/2016 09:02 AM, Thomas Huth wrote:
On 30.11.2016 00:05, Eero Tamminen wrote:
On 11/29/2016 11:49 PM, Thomas Huth wrote:
Am Tue, 29 Nov 2016 18:55:57 +0100 (CET)
schrieb Anders Eriksson <ae@xxxxxx>:
There is a bug in all versions of Hatari I've tried; if you record a
Falcon video, and it change the screen size, the recording will abort
if you are using 32-bit rendering. Only with 16-bit the recording
will continue. Yes this is with --force-max.
>>>
I think this happens because we're rendering Falcon hi-color mode
always with 16 bpp by default, while the indexed resolutions are
rendered into 32 bpp. So if a demo switches between hi-color and
indexed mode, the recording has to be stopped because the bpp of the
host screen changed.
Maybe we should rather always use 32 bpp nowadays, e.g. with a patch
like this:
....
... but this needs a bit of testing before I dare to commit it,
I tested Falcon desktop modes, and those work fine with the patch.
to see whether it has performance impacts or other problems...
>>
Hm, isn't it rather allowing user to force
the bitdepth (which is preferable), instead
of using fixed 32-bit bitdepth?
Yeah, sure, I just had in mind that likely 99% of all users are using
the default value for nForceBpp and thus the code will use 32 bpp here
with my patch.
In that case, it just needs to be documented that one may
get more performance with "--bpp 16". I think it's valid
change as it actually makes "--bpp" option work as expected.
- Eero