| Re: [hatari-devel] Hatari's SDL2-port screen update bug |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] Hatari's SDL2-port screen update bug
- From: David Savinkoff <dsavnkff@xxxxxxxxx>
- Date: Sat, 10 Sep 2016 14:06:32 -0600 (MDT)
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telus.net; s=neo; t=1473537992; bh=H5is8moXgllZeu6DUP3algbrGC+n4mKxULtWVikHCak=; h=Date:From:To:In-Reply-To:Subject; b=sQA86rskcLO2oEoOIcqsc+FUuqPSmEVgf0h0W00RCf16y7VCSYRbHxXCq5myEHJZN Pt7z/rWndlvF/NdikAsqwRsttx5z4Ek/g8P5O7W2furVgKf5v66/i0hJ2GOfeQe/Hv vYO1rwcF1ntb3eLbdHpdbnLpOFC4GIxOD2FeocCIx747YvM+ydpPHEtDt7bEkPOW5x xtfUYtZRLwpds+/GpIzEyFTebPMQq0+FPrFc9exKtfz10Rz5XagWEpPOW9+Ek+JRtD yxz2u90pu1adTmy7kJ71UcUKhffV8Xc80DQ4azc70bk890If+waU/dfyMA519UGpmr bjB427Iavq6YA==
- Thread-index: f+uL5gSmHsdJEePH5gKSEGebwpxtOg==
- Thread-topic: Hatari's SDL2-port screen update bug
----- Thomas Huth wrote:
> Am Thu, 8 Sep 2016 21:54:39 +0300
> schrieb Eero Tamminen:
>
> > Hi,
> >
> > On 09/08/2016 10:45 AM, Thomas Huth wrote:
> > >> As result, e.g. Hatari dialogs aren't in some cases shown
> > >> with SDL2 until user blindly interacts with them first.
> > >
> > > I've never seen that behavior so far, can you give an example
> > > how to reproduce this issue?
> >
> > Invoke debugger and use "savestate" command few times.
> >
> > When the file already exists, a query dialog is popped
> > up. With SDL2, Hatari screen isn't refreshed, unlike
> > with SDL1.
>
> Actually, it seems to me that this is not a screen refresh problem, but
> it rather seems like SDL2 generates a keyboard event for the RETURN key
> that you use to finish the "savestate" command in the debugger.
Is it possible the Return code is left in the keyboard buffer?
There have been times in past with various o/s' where I had
to make a flush() subroutine to clear the keyboard buffer after
use, and even before use on occasions.
> Thus Hatari opens the dialog and immediately closes it again because it
> thinks that the user hit RETURN to choose the OK button.
> Not sure why SDL2 generates a keyboard event in this case, since the
> focus should be in the debugger terminal window. Sounds like a SDL2 bug
> to me.
> We could maybe somehow work around this problem by flushing the event
> queue ... but I currently rather wonder whether it's a good idea to
> call the memory snapshot functions with bConfirm=true. If the users
> are working in the debugger terminal, I think they do not really
> expect a dialog to pop up in the main window. So maybe that dialog
> should rather be avoided and you should prompt for yes/no in the
> terminal window? Or simply do not ask the user at all and always
> overwrite the destination file (aka. you should know what you're doing
> when using the debugger)?
> What do you think?
>
> Thomas
>
>
>