Re: [hatari-devel] SDL GUI code cleanup

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi,

On sunnuntai 14 kesäkuu 2015, Eero Tamminen wrote:
> On sunnuntai 14 kesäkuu 2015, Thomas Huth wrote:
> > For the SG_END changes, it's likely ok since this is not a functional
> > change
> 
> OK.

I've pushed all the changes in now, split into few commits.


I'm seeing a bug in SDL GUI dialog handling, but I think
it's an already existing bug that is just now more visible.

The bug is that if I use SDL GUI file selector, Alert
dialog default button's ".flags" value (0x4) moves to its
".state" value and ".flags" value is zeroed.  It looks like
something would be overwriting unrelated memory as I don't
see flags values being changed anywhere in code, their
values are just initialized in the structs and never
changed afterwards.


> > (but maybe name it differently - all the other constants do not
> > have an underscore in the name).
> 
> I tried that, but IMHO SGEND doesn't look like it has "SG" prefix
> like the other types.  I.e. I'm not completely happy with either
> SG_END nor SGEND name.
> 
> Any proposals for another name that looks more like a name
> for a terminator token?

I changed it to SGSTOP.


	- Eero