| Re: [hatari-devel] SDL GUI code cleanup |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
Hi,
On sunnuntai 20 syyskuu 2015, Eero Tamminen wrote:
> I'm seeing a bug in SDL GUI dialog handling, but I think
> it's an already existing bug that is just now more visible.
>
> The bug is that if I use SDL GUI file selector, Alert
> dialog default button's ".flags" value (0x4) moves to its
> ".state" value and ".flags" value is zeroed. It looks like
> something would be overwriting unrelated memory as I don't
> see flags values being changed anywhere in code, their
> values are just initialized in the structs and never
> changed afterwards.
It was redundant code that was earlier harmless, but now
caused wrong memory value to be set:
http://hg.tuxfamily.org/mercurialroot/hatari/hatari/rev/535d7def5dd2
I did also some additional refactoring + added some debugging
code to sdlgui.c (which is naturally disabled by default).
- Eero