| Re: [hatari-devel] beautify sdl-gui underlines patch |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] beautify sdl-gui underlines patch
- From: David Savinkoff <dsavnkff@xxxxxxxxx>
- Date: Tue, 3 Mar 2015 15:07:37 -0700 (MST)
- Thread-index: r7HZThD/SzLm0LjpPDgtYqs7DVvadA==
- Thread-topic: beautify sdl-gui underlines patch
Hi Eero,
While I was playing with your arrows.diff patch, I
discovered that Hatari (with and without your patch)
decreases the screen height with <alt><up arrow>
when it would be better to increase the height.
This patch arrows2.diff improves on arrows.diff
by fixing the aforementioned problem.
Sincerely,
David Savinkoff
diff -ur src/gui-sdl/dlgJoystick.c
--- a/src/gui-sdl/dlgJoystick.c Wed Feb 04 22:19:34 2015 +0200
+++ b/src/gui-sdl/dlgJoystick.c Wed Feb 04 22:21:59 2015 +0200
@@ -48,8 +48,8 @@
{ SGBOX, 0, 0, 5,11, 22,1, NULL },
{ SGTEXT, 0, 0, 6,11, 20,1, sSdlStickName },
- { SGBUTTON, 0, 0, 4,11, 1,1, "\x04", SG_SHORTCUT_UP },
- { SGBUTTON, 0, 0, 27,11, 1,1, "\x03", SG_SHORTCUT_DOWN },
+ { SGBUTTON, 0, 0, 4,11, 1,1, "\x02", SG_SHORTCUT_DOWN },
+ { SGBUTTON, 0, 0, 27,11, 1,1, "\x01", SG_SHORTCUT_UP },
{ SGCHECKBOX, 0, 0, 2,13, 17,1, "Enable _autofire" },
diff -ur src/gui-sdl/dlgScreen.c
--- a/src/gui-sdl/dlgScreen.c Wed Feb 04 22:19:34 2015 +0200
+++ b/src/gui-sdl/dlgScreen.c Wed Feb 04 22:21:59 2015 +0200
@@ -66,9 +66,9 @@
{ SGTEXT, 0, 0, 8,12, 4,1, sVdiWidth },
{ SGBUTTON, 0, 0, 13,12, 1,1, "\x03", SG_SHORTCUT_RIGHT },
{ SGTEXT, 0, 0, 4,13, 1,1, "x" },
- { SGBUTTON, 0, 0, 6,13, 1,1, "\x04", SG_SHORTCUT_UP },
+ { SGBUTTON, 0, 0, 6,13, 1,1, "\x02", SG_SHORTCUT_DOWN },
{ SGTEXT, 0, 0, 8,13, 4,1, sVdiHeight },
- { SGBUTTON, 0, 0, 13,13, 1,1, "\x03", SG_SHORTCUT_DOWN },
+ { SGBUTTON, 0, 0, 13,13, 1,1, "\x01", SG_SHORTCUT_UP },
{ SGRADIOBUT, SG_EXIT, 0, 18,11, 11,1, " _2 colors" },
{ SGRADIOBUT, SG_EXIT, 0, 18,12, 11,1, " _4 colors" },
@@ -138,9 +138,9 @@
{ SGTEXT, 0, 0, 37,8, 4,1, sMaxWidth },
{ SGBUTTON, 0, 0, 43,8, 1,1, "\x03", SG_SHORTCUT_RIGHT },
{ SGTEXT, 0, 0, 33,9, 1,1, "x" },
- { SGBUTTON, 0, 0, 35,9, 1,1, "\x04", SG_SHORTCUT_UP },
+ { SGBUTTON, 0, 0, 35,9, 1,1, "\x02", SG_SHORTCUT_DOWN },
{ SGTEXT, 0, 0, 37,9, 4,1, sMaxHeight },
- { SGBUTTON, 0, 0, 43,9, 1,1, "\x03", SG_SHORTCUT_DOWN },
+ { SGBUTTON, 0, 0, 43,9, 1,1, "\x01", SG_SHORTCUT_UP },
{ SGBOX, 0, 0, 1,12, 50,5, NULL },
{ SGTEXT, 0, 0, 7,13, 16,1, "Screen capture" },