Re: [hatari-devel] beautify sdl-gui underlines patch

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi,

On tiistai 03 helmikuu 2015, David Savinkoff wrote:
> The following are more observations (not suggestions):
> 
> I noticed an 'x' beside 'Max zoomed win:' in the picture
> I sent previously 'Best-Hatari-v1.8.0.png'. I also noticed
> this 'x' beside the VDI size buttons, and finally figured
> that its meaning is to use the 'up' and 'down' arrow keys.

It's just the visual 'x' symbol from "<width> x <height>",
it has nothing to do with keyboard shortcuts. :-)


> Note that the 'up' and 'down' arrow key symbols exist
> in hatari/src/gui-sdl/font5x8.bmp and could be used.

I'm not sure it's a good idea, it looks a bit weird.
Try the attached patch.


> Also, the two lower arrow buttons could be underlined
> to provide a hint.

NAK.  Underline doesn't fit into arrow box.

Btw. Common keyboard shortcuts like these are already listed
in the Hatari manual page and I just added section on them
also to the HTML manual.


	- Eero
 
> ----- David Savinkoff wrote:
> > Hi,
> > 
> > The sdl-gui looks good. Thanks. Enclosed is a picture
> > to compare with the previous I sent.
> > 
> > Sincerely,
> > David Savinkoff
> > 
> > ----- Eero Tamminen wrote:
> > > Hi,
> > > 
> > > I think this needs opinions from others.
> > > 
> > > On maanantai 02 helmikuu 2015, David Savinkoff wrote:
> > > > Good thing you said no, because this one is better.
> > > 
> > > First you were saying that you want shortcut indicator to be less
> > > visible, but your new patch makes it much more visible?
> > > 
> > > 
> > > I saw from your screenshots what I think you had an issue with,
> > > underlines going over the text on next line.  What about attached
> > > patch?
> > > 
> > > With it the underline in non-zoomed mode doesn't go over next line
> > > text (like currently), it doesn't go over button border (like in
> > > your previous patch).  And it uses more visible color (in non-zoomed
> > > mode) because otherwise underline could be mistook for a badly
> > > rendered font.
> > > 
> > > 	- Eero

diff -r 097901d55330 src/gui-sdl/dlgJoystick.c
--- a/src/gui-sdl/dlgJoystick.c	Wed Feb 04 22:19:34 2015 +0200
+++ b/src/gui-sdl/dlgJoystick.c	Wed Feb 04 22:21:59 2015 +0200
@@ -48,8 +48,8 @@
 
 	{ SGBOX, 0, 0, 5,11, 22,1, NULL },
 	{ SGTEXT, 0, 0, 6,11, 20,1, sSdlStickName },
-	{ SGBUTTON, 0, 0,  4,11, 1,1, "\x04", SG_SHORTCUT_UP },
-	{ SGBUTTON, 0, 0, 27,11, 1,1, "\x03", SG_SHORTCUT_DOWN },
+	{ SGBUTTON, 0, 0,  4,11, 1,1, "\x02", SG_SHORTCUT_UP },
+	{ SGBUTTON, 0, 0, 27,11, 1,1, "\x01", SG_SHORTCUT_DOWN },
 
 	{ SGCHECKBOX, 0, 0, 2,13, 17,1, "Enable _autofire" },
 
diff -r 097901d55330 src/gui-sdl/dlgScreen.c
--- a/src/gui-sdl/dlgScreen.c	Wed Feb 04 22:19:34 2015 +0200
+++ b/src/gui-sdl/dlgScreen.c	Wed Feb 04 22:21:59 2015 +0200
@@ -66,9 +66,9 @@
 	{ SGTEXT,     0, 0,  8,12, 4,1, sVdiWidth },
 	{ SGBUTTON,   0, 0, 13,12, 1,1, "\x03", SG_SHORTCUT_RIGHT },
 	{ SGTEXT,     0, 0,  4,13, 1,1, "x" },
-	{ SGBUTTON,   0, 0,  6,13, 1,1, "\x04", SG_SHORTCUT_UP },
+	{ SGBUTTON,   0, 0,  6,13, 1,1, "\x02", SG_SHORTCUT_UP },
 	{ SGTEXT,     0, 0,  8,13, 4,1, sVdiHeight },
-	{ SGBUTTON,   0, 0, 13,13, 1,1, "\x03", SG_SHORTCUT_DOWN },
+	{ SGBUTTON,   0, 0, 13,13, 1,1, "\x01", SG_SHORTCUT_DOWN },
 
 	{ SGRADIOBUT, SG_EXIT, 0, 18,11, 11,1, " _2 colors" },
 	{ SGRADIOBUT, SG_EXIT, 0, 18,12, 11,1, " _4 colors" },
@@ -138,9 +138,9 @@
 	{ SGTEXT,     0, 0, 37,8,  4,1, sMaxWidth },
 	{ SGBUTTON,   0, 0, 43,8,  1,1, "\x03", SG_SHORTCUT_RIGHT },
 	{ SGTEXT,     0, 0, 33,9,  1,1, "x" },
-	{ SGBUTTON,   0, 0, 35,9,  1,1, "\x04", SG_SHORTCUT_UP },
+	{ SGBUTTON,   0, 0, 35,9,  1,1, "\x02", SG_SHORTCUT_UP },
 	{ SGTEXT,     0, 0, 37,9,  4,1, sMaxHeight },
-	{ SGBUTTON,   0, 0, 43,9,  1,1, "\x03", SG_SHORTCUT_DOWN },
+	{ SGBUTTON,   0, 0, 43,9,  1,1, "\x01", SG_SHORTCUT_DOWN },
 
 	{ SGBOX,      0, 0,  1,12, 50,5, NULL },
 	{ SGTEXT,     0, 0,  7,13, 16,1, "Screen capture" },